Skip to content

revert(Dialog): revert InvokeAsync StateHasChanged #5632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2025
Merged

revert(Dialog): revert InvokeAsync StateHasChanged #5632

merged 2 commits into from
Mar 15, 2025

Conversation

@densen2014
Copy link
Member

@densen2014 densen2014 commented Mar 14, 2025 •
edited by ArgoZhang
Loading

Issues

fixes #5631
fixes #5633

Summary By Copilot

This pull request includes several changes to the BootstrapBlazor project, focusing on version updates and improvements to asynchronous handling in the Dialog component.

Version Update:

Asynchronous Handling Improvements:

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 14, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request fixes issue #5631 by modifying the Show method in Dialog.razor.cs to be asynchronous and use InvokeAsync when calling StateHasChanged. This ensures that the UI is updated correctly when the dialog is shown asynchronously.

Sequence diagram for Dialog.Show() asynchronous call

sequenceDiagram
    participant Dialog as Dialog
    participant UI as UI

    Dialog->>Dialog: Show(DialogOption option)
    activate Dialog
    Dialog->>Dialog: DialogParameters.Add(parameters, (_isKeyboard, _isBackdrop))
    Dialog->>UI: InvokeAsync(StateHasChanged)
    activate UI
    UI-->>Dialog: 
    deactivate UI
    deactivate Dialog
Loading

File-Level Changes

Change Details Files
The Show method in Dialog.razor.cs was modified to be asynchronous and to use InvokeAsync when calling StateHasChanged.
  • The Show method was changed from private Task Show(DialogOption option) to private async Task Show(DialogOption option).
  • The StateHasChanged() call was wrapped in InvokeAsync to ensure it is called on the UI thread.
 src/BootstrapBlazor/Components/Dialog/Dialog.razor.cs
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
Copy link

bb-auto bot commented Mar 14, 2025

Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang March 14, 2025 17:00
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @densen2014 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The change from Task Show to async Task Show is good, but it might be worth adding a comment explaining why this change is necessary.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Mar 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (79fce04) to head (3bb564f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #5632   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          653       653           
  Lines        29344     29343    -1     
  Branches      4176      4179    +3     
=========================================
- Hits         29344     29343    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title 修复Dialog.Show()异步调用 StateHasChanged() 出错 revert(Dialog): revert InvokeAsync StateHasChanged Mar 15, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) March 15, 2025 02:07
@ArgoZhang ArgoZhang disabled auto-merge March 15, 2025 02:09
@ArgoZhang ArgoZhang merged commit d32b604 into main Mar 15, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the Dialog.Show异步渲染_#5631 branch March 15, 2025 02:11
@ArgoZhang ArgoZhang self-assigned this Mar 15, 2025
@ArgoZhang ArgoZhang added the enhancement New feature or request label Mar 15, 2025
@ArgoZhang ArgoZhang added this to the v9.4.0 milestone Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArgoZhang ArgoZhang ArgoZhang approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@ArgoZhang ArgoZhang

Labels

enhancement New feature or request

Projects

None yet

Milestone

v9.4.0

Development

Successfully merging this pull request may close these issues.

refactor(Dialog): revert InvokeAsync StateHasChanged

3 participants

@densen2014 @ArgoZhang